This repository has been archived by the owner on Feb 15, 2019. It is now read-only.
Make drawer items extendable and support non-item contents in the drawer #251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dantman
force-pushed
the
extendable-drawer-items
branch
from
0721da1 to
87aa6ac
Compare
|
CC: @sibelius |
|
@brentvatne If I rebase this will it get merged? |
|
@dantman , Good job! It is exactly what I need! Any updates? |
|
@RomanPerin The code is ready, everything right now is depending on a maintainer reviewing it and saying they'll merge it. |
|
hello! if you rebase this I can review it today |
…item components
DrawerNavigation{Child,Item} drawerItems are now rendered directly instead of being used as plain JS objects.
…lence This allows DrawerNavigationChild and DrawerNavigationItem to be extended with a project's patterns.
…g getters or methods on the class
- Include renderHeader and renderDrawerItems so the replacement function is able to replicate the standard drawer navigation view layout - Include the internal styles used as containerStyle and scrollableContentContainerStyle so the styles can also be replicated - Make renderDrawerItems accept items from an arg instead of a prop so that the items list can be filtered
dantman
force-pushed
the
extendable-drawer-items
branch
from
87aa6ac to
5c3b758
Compare
|
Rebased and included the additional |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DrawerNavigationChild<DrawerNavigationChild>...</DrawerNavigationChild>can be used on its own which by default injects the children into the drawerDrawerNavigationChildcan definerenderDrawerItem()andrenderContent()to render to drawer children or route contentDrawerNavigationItemclassDrawerNavigationItemcan override class getters to override props handling